Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript error in knockout counter tests #55

Open
Hyodar opened this issue Jul 22, 2022 · 0 comments
Open

Typescript error in knockout counter tests #55

Hyodar opened this issue Jul 22, 2022 · 0 comments

Comments

@Hyodar
Copy link

Hyodar commented Jul 22, 2022

Hello there!

It seems that the commit 73440a9 introduced a typescript error in some TestKnockoutCounter.ts unit tests, since the name hre is not known.

When writing tests in Typescript, the globally injected hre will not be recognized (confirmed by the docs), so one way to solve this would be to either import hre through import hre from "hardhat" or, since only the ethers module is being used, just import { ethers } from "hardhat" and changing usages accordingly would work. I've done this locally some days ago to be able to run the tests.

Let me know what you think. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant