Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BUG ] Version check needs fix in /samples/identity/graphql_pagation.py #1281

Open
dk-fern opened this issue Feb 10, 2025 · 4 comments
Open
Assignees
Labels
bug 🐛 Something isn't working code samples Functioning sample code to get you started identity protection Identity Protection issues and questions

Comments

@dk-fern
Copy link

dk-fern commented Feb 10, 2025

Describe the bug
Version check logic needs to satisfy minor version higher than "11" even if major version is higher than "1.2"

To Reproduce
Run script with a major version higher than 1.2 and a minor version lower than 11. e.g. falconpy version 1.4.6

Expected behavior
Script raises error even though major version is above version needed.

Environment (please complete the following information):

  • OS: Windows
  • Python: 3.13
  • FalconPy: 1.4.6

Additional context
Logic should be updated to something like this so that if a major version is above 1.2 it will pass version check even if the minor version is less than 11:

if major_minor > 1.2:
valid_version = True
elif major_minor == 1.2 and int(vers[2]) >= 11:
valid_version = True

@dk-fern dk-fern added the bug 🐛 Something isn't working label Feb 10, 2025
@jshcodes jshcodes self-assigned this Feb 10, 2025
@jshcodes jshcodes added code samples Functioning sample code to get you started identity protection Identity Protection issues and questions labels Feb 12, 2025
@Gage-BCCA
Copy link

I love the project and want to contribute. If you guys are cool with a newbie pitching in... can I take this one?

@jshcodes
Copy link
Member

I love the project and want to contribute. If you guys are cool with a newbie pitching in... can I take this one?

Absolutely, we would be excited to see your contribution!

Since this issue is related to a sample, post your PR to the samples branch. If you have any questions, just let us know.

@Gage-BCCA
Copy link

I love the project and want to contribute. If you guys are cool with a newbie pitching in... can I take this one?

Absolutely, we would be excited to see your contribution!

Since this issue is related to a sample, post your PR to the samples branch. If you have any questions, just let us know.

I might have spoken too soon. I am doing this as an individual and not related to my job -- so I don't have access to an API, which appears to be a requirement to run tests.

If I've misunderstood, let me know and I'll continue to work. I have the logic changed already -- just can't test it 🙃

@jshcodes
Copy link
Member

jshcodes commented Mar 7, 2025

If you submit your proposed change, we can test it before merging. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working code samples Functioning sample code to get you started identity protection Identity Protection issues and questions
Projects
None yet
Development

No branches or pull requests

3 participants