add name and id min size check, issue bitcoin#354

(cherry picked from commit c4e6041)

Author: artem-bv

src/platform/nf-token/nf-token-protocol-reg-tx.cpp

@@ -36,7 +36,8 @@ namespace Platform
         if (nftProto.nftRegSign < static_cast<uint8_t>(NftRegSignMin) || nftProto.nftRegSign > static_cast<uint8_t>(NftRegSignMax))
             return state.DoS(10, false, REJECT_INVALID, "bad-nft-proto-reg-tx-reg-sign");
 
-        if (nftProto.tokenProtocolName.size() > NfTokenProtocol::TOKEN_PROTOCOL_NAME_MAX)
+        if (nftProto.tokenProtocolName.size() < NfTokenProtocol::TOKEN_PROTOCOL_NAME_MIN
+        || nftProto.tokenProtocolName.size() > NfTokenProtocol::TOKEN_PROTOCOL_NAME_MAX)
             return state.DoS(10, false, REJECT_INVALID, "bad-nft-proto-reg-tx-proto-name");
 
         if (nftProto.tokenMetadataMimeType.size() > NfTokenProtocol::TOKEN_METADATA_MIMETYPE_MAX)

src/platform/nf-token/nf-token-protocol.h

@@ -57,7 +57,9 @@ namespace Platform
         CKeyID tokenProtocolOwnerId;
         //TODO: add admin key to the protocol structure. add option to use setup admin key rights including tranfering ownership
 
+        static const unsigned TOKEN_PROTOCOL_ID_MIN = 3;
         static const unsigned TOKEN_PROTOCOL_ID_MAX = 12;
+        static const unsigned TOKEN_PROTOCOL_NAME_MIN = 3;
         static const unsigned TOKEN_PROTOCOL_NAME_MAX = 24;
         static const unsigned TOKEN_METADATA_SCHEMA_URI_MAX = 128;
         static const unsigned TOKEN_METADATA_MIMETYPE_MAX = 32;

src/platform/nf-token/nft-protocol-reg-tx-builder.h

@@ -20,17 +20,18 @@ namespace Platform
         NftProtocolRegTxBuilder & SetTokenProtocol(const json_spirit::Value & tokenProtocolId)
         {
             auto nftProtoStr = tokenProtocolId.get_str();
-            if (nftProtoStr.size() > NfTokenProtocol::TOKEN_PROTOCOL_ID_MAX)
-                throw JSONRPCError(RPC_INVALID_PARAMETER, "NFT protocol ID is longer than permitted");
+            if (nftProtoStr.size() < NfTokenProtocol::TOKEN_PROTOCOL_ID_MIN || nftProtoStr.size() > NfTokenProtocol::TOKEN_PROTOCOL_ID_MAX)
+                throw JSONRPCError(RPC_INVALID_PARAMETER, "NFT protocol ID must be between 3 and 12 symbols long");
             m_nftProto.tokenProtocolId = StringToProtocolName(nftProtoStr.c_str());
             return *this;
         }
 
         NftProtocolRegTxBuilder & SetTokenProtocolName(const json_spirit::Value & tokenProtocolName)
         {
             m_nftProto.tokenProtocolName = tokenProtocolName.get_str();
-            if (m_nftProto.tokenProtocolName.size() > NfTokenProtocol::TOKEN_PROTOCOL_NAME_MAX)
-                throw JSONRPCError(RPC_INVALID_PARAMETER, "NFT Protocol name is longer than permitted");
+            if (m_nftProto.tokenProtocolName.size() < NfTokenProtocol::TOKEN_PROTOCOL_NAME_MIN
+            || m_nftProto.tokenProtocolName.size() > NfTokenProtocol::TOKEN_PROTOCOL_NAME_MAX)
+                throw JSONRPCError(RPC_INVALID_PARAMETER, "NFT Protocol name must be between 3 and 24 symbols long");
             return *this;
         }