Skip to content

Commit 1cbac34

Browse files
committed
Reword pgbackrest log.path validation rules.
1 parent e6beb45 commit 1cbac34

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

config/crd/bases/postgres-operator.crunchydata.com_postgresclusters.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4589,18 +4589,18 @@ spec:
45894589
x-kubernetes-validations:
45904590
- message: pgbackrest sidecar log path is restricted to an existing
45914591
additional volume
4592-
rule: '!has(self.log) || !has(self.log.path) || self.log.path.startsWith("/volumes/")'
4592+
rule: '!self.?log.path.hasValue() || self.log.path.startsWith("/volumes/")'
45934593
- message: repo host log path is restricted to an existing additional
45944594
volume
4595-
rule: '!has(self.repoHost) || !has(self.repoHost.log) || !has(self.repoHost.log.path)
4596-
|| self.repoHost.volumes.additional.exists(x, self.repoHost.log.path.startsWith("/volumes/"+x.name))'
4595+
rule: '!self.?repoHost.log.path.hasValue() || self.repoHost.volumes.additional.exists(x,
4596+
self.repoHost.log.path.startsWith("/volumes/"+x.name))'
45974597
- message: backup jobs log path is restricted to an existing additional
45984598
volume
4599-
rule: '!has(self.jobs) || !has(self.jobs.log) || !has(self.jobs.log.path)
4600-
|| self.jobs.volumes.additional.exists(x, self.jobs.log.path.startsWith("/volumes/"+x.name))'
4599+
rule: '!self.?jobs.log.path.hasValue() || self.jobs.volumes.additional.exists(x,
4600+
self.jobs.log.path.startsWith("/volumes/"+x.name))'
46014601
- message: pgbackrest log-path must be set via the various log.path
46024602
fields in the spec
4603-
rule: '!has(self.global) || !(''log-path'' in self.global)'
4603+
rule: '!self.?global["log-path"].hasValue()'
46044604
snapshots:
46054605
description: VolumeSnapshot configuration
46064606
properties:

pkg/apis/postgres-operator.crunchydata.com/v1/pgbackrest_types.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ import (
99
)
1010

1111
// PGBackRestArchive defines a pgBackRest archive configuration
12-
// +kubebuilder:validation:XValidation:rule=`!has(self.log) || !has(self.log.path) || self.log.path.startsWith("/volumes/")`,message=`pgbackrest sidecar log path is restricted to an existing additional volume`
13-
// +kubebuilder:validation:XValidation:rule=`!has(self.repoHost) || !has(self.repoHost.log) || !has(self.repoHost.log.path) || self.repoHost.volumes.additional.exists(x, self.repoHost.log.path.startsWith("/volumes/"+x.name))`,message=`repo host log path is restricted to an existing additional volume`
14-
// +kubebuilder:validation:XValidation:rule=`!has(self.jobs) || !has(self.jobs.log) || !has(self.jobs.log.path) || self.jobs.volumes.additional.exists(x, self.jobs.log.path.startsWith("/volumes/"+x.name))`,message=`backup jobs log path is restricted to an existing additional volume`
15-
// +kubebuilder:validation:XValidation:rule=`!has(self.global) || !('log-path' in self.global)`,message=`pgbackrest log-path must be set via the various log.path fields in the spec`
12+
// +kubebuilder:validation:XValidation:rule=`!self.?log.path.hasValue() || self.log.path.startsWith("/volumes/")`,message=`pgbackrest sidecar log path is restricted to an existing additional volume`
13+
// +kubebuilder:validation:XValidation:rule=`!self.?repoHost.log.path.hasValue() || self.repoHost.volumes.additional.exists(x, self.repoHost.log.path.startsWith("/volumes/"+x.name))`,message=`repo host log path is restricted to an existing additional volume`
14+
// +kubebuilder:validation:XValidation:rule=`!self.?jobs.log.path.hasValue() || self.jobs.volumes.additional.exists(x, self.jobs.log.path.startsWith("/volumes/"+x.name))`,message=`backup jobs log path is restricted to an existing additional volume`
15+
// +kubebuilder:validation:XValidation:rule=`!self.?global["log-path"].hasValue()`,message=`pgbackrest log-path must be set via the various log.path fields in the spec`
1616
type PGBackRestArchive struct {
1717
v1beta1.PGBackRestArchive `json:",inline"`
1818
}

0 commit comments

Comments
 (0)