Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple imports environments #3

Open
CryZe opened this issue Apr 4, 2018 · 0 comments
Open

Handle multiple imports environments #3

CryZe opened this issue Apr 4, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@CryZe
Copy link
Owner

CryZe commented Apr 4, 2018

I'm not actually sure how they are being handled at the moment, but if they actually all generate proper methods on the Imports trait, then we don't actually handle any name collisions properly as far as I can tell. This needs to be resolved by either prefixing the function names by the environment name or splitting up the trait. Additionally prefixing is probably not necessary if there's only a single environment and probably not when there's no collisions in the first place (although the latter sounds like an option you might want to change).

@CryZe CryZe added the bug Something isn't working label Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant