Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if you specify "Degree Plan" in the CSV file, but no term data is provided, read_csv() returns a Tuple rather than a DegreePlan object #63

Closed
heileman opened this issue Aug 27, 2019 · 3 comments
Closed

if you specify "Degree Plan" in the CSV file, but no term data is provided, read_csv() returns a Tuple rather than a DegreePlan object #63

heileman opened this issue Aug 27, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@heileman
Copy link
Contributor

No description provided.

@heileman
Copy link
Contributor Author

This should probably throw an error. I.e., if any courses are not assigned to a term, the degree plan will not be valid.

@haydenfree haydenfree mentioned this issue Aug 28, 2019
Closed
@haydenfree
Copy link
Member

haydenfree commented Aug 28, 2019 •
edited
Loading

This should probably throw an error. I.e., if any courses are not assigned to a term, the degree plan will not be valid.

I agree. The Tuple is not documented and is unexpected/unpredictable behavior.

@haydenfree haydenfree added the bug Something isn't working label Feb 15, 2020
@haydenfree
Copy link
Member

Fixed by 2b3fd12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@heileman @haydenfree @orhanabar