Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Calculated Delay Factor #85

Closed
benhawk1 opened this issue Feb 10, 2020 · 4 comments
Closed

Error in Calculated Delay Factor #85

benhawk1 opened this issue Feb 10, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@benhawk1
Copy link

When creating degree plans, I noticed that several of the courses in the plan were displaying delay factors that appeared to be incorrect. Included in attachments are screenshots of the erroneous delay factors, as well as a word document containing code that can be used to replicate the display for errors 1 through 3.

Currently using CurricularAnalytics v0.6.6 and Julia v1.2.0, though this error was also occurring on CurricularAnalytics v0.6.3.

(Notes: Correct value for photo 1's delay factor is 7 (displayed as 4), photo 2's factor should be 7 (displayed as 5), photo 3 should be 8 (displayed as 6), photo 4 should be 6 (displayed as 5))

Please let me know if you need any more information regarding the bug, and thank you for your help!

Erroneous Delay Factor 1
Erroneous Delay Factor 2
Erroneous Delay Factor 3
Erroneous Delay Factor 4

ENME Curricular Analytics Code.docx

@haydenfree
Copy link
Member

Ben,

Thanks so much for bringing this bug to our attention. There should be tests built in that check the metrics are being calculated correctly, but clearly at the least the visualization isn't showing the correct numbers. We will work to correct this as soon as possible.

@haydenfree haydenfree added the bug Something isn't working label Feb 10, 2020
@heileman
Copy link
Contributor

heileman commented Feb 10, 2020

Ben, can you send me the CSV files you used to create these programs? (greg.heileman@gmail.com)
Thanks for reporting the bug.
-Greg

@benhawk1
Copy link
Author

Sure thing! I'll send them now.

@heileman
Copy link
Contributor

Fixed: delay_factor() was not finding all long paths, now it does.
Screen Shot 2020-02-13 at 12 52 29 PM
Screen Shot 2020-02-13 at 12 53 08 PM
Screen Shot 2020-02-13 at 12 53 43 PM
Screen Shot 2020-02-13 at 12 50 31 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants