Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devise-fido-u2f interferes with custom Devise::SessionsController#create #11

Open
brianewell opened this issue Aug 16, 2018 · 0 comments
Assignees

Comments

@brianewell
Copy link

Standard Devise actions can be overridden with customized controller code as follows:
config/routes.rb:

devise_for :users, controllers: { sessions: 'users/sessions' }

app/controllers/users/sessions_controller.rb:

class Users::SessionsController < Devise::SessionsController
  # POST /resource/sign_in
  def create
    raise 'this should get your attention'
    super
  end
end

After enabling :fido_usf_registerable and :fido_usf_authenticatable in my user model, I found that Users::SessionsController#create was never being called, despite the user still being successfully signed in.

Ruby v2.4.3
Rails v5.1.6
Devise FIDO USF v0.1.9

@brianewell brianewell changed the title devise-fido-u2f gem interferes with customized Devise::SessionsController#create devise-fido-u2f interferes with custom Devise::SessionsController#create Aug 16, 2018
@CyberDeck CyberDeck self-assigned this Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants