Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default TagCheck rules #265

Open
kam193 opened this issue Sep 19, 2024 · 0 comments
Open

Default TagCheck rules #265

kam193 opened this issue Sep 19, 2024 · 0 comments
Assignees
Labels
accepted This issue was accepted, we will work on this at some point bug Something isn't working service-tagcheck

Comments

@kam193
Copy link

kam193 commented Sep 19, 2024

Describe the bug
I've just recognized that the default TagCheck rules config points to the file in Azure, but there is also a file in Github that looks to be newer? extended?

So: question/bug: are both files relevant, or do you suggest using only one of them?

To Reproduce
Steps to reproduce the behavior:

  1. Look at the file provided in service manifest: https://github.com/CybercentreCanada/assemblyline-service-yara/blob/master/tagcheck/service_manifest.yml
  2. Compare with https://github.com/CybercentreCanada/assemblyline-service-yara/blob/master/tagcheck/rules/tagcheck.rules

Expected behavior

Screenshots

Environment (please complete the following information if pertinent):

  • Assemblyline Version: TagCheck 4.5.0.17

Additional context

@kam193 kam193 added assess We still haven't decided if this will be worked on or not bug Something isn't working labels Sep 19, 2024
@gdesmar gdesmar added accepted This issue was accepted, we will work on this at some point service-tagcheck and removed assess We still haven't decided if this will be worked on or not labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted This issue was accepted, we will work on this at some point bug Something isn't working service-tagcheck
Projects
None yet
Development

No branches or pull requests

3 participants