Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatmerge clobbers metadata.component #183

Open
electricgull opened this issue Nov 8, 2022 · 2 comments · May be fixed by #256
Open

Flatmerge clobbers metadata.component #183

electricgull opened this issue Nov 8, 2022 · 2 comments · May be fixed by #256

Comments

@electricgull
Copy link

Flatmerge clobbers metadata.component when the new metadata is initiated and the only sub-element that persists is metadata.tool.

cyclonedx-dotnet-library/src/CycloneDX.Utils/Merge.cs

Line 62 in b5fbaf6

result.Metadata = new Metadata

If you can advise on how this should be handled, I'm happy to create a pull request with the change. Possibly, convert metadata.component to a List and then merge like metadata.tool?

This bug is linked to the following issues

#CycloneDX/cyclonedx-cli#218
#CycloneDX/cyclonedx-cli#219
@electricgull
Copy link
Author

This was fixed in the cli v0.24.2, but it looks like it's still present in the library.

CycloneDX/cyclonedx-cli@148e8ed

@jimklimov
Copy link
Contributor

jimklimov commented Sep 22, 2023 •
edited
Loading

Should get fixed by #256 on the library side

@jimklimov jimklimov linked a pull request Sep 22, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bom: initialize its own metadata jimklimov/cyclonedx-dotnet-library
2 participants
@jimklimov @electricgull