Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please do not reuse propertyType for "environmentVar " #248

Open
jkowalleck opened this issue Jun 16, 2023 · 1 comment
Open

Please do not reuse propertyType for "environmentVar " #248

jkowalleck opened this issue Jun 16, 2023 · 1 comment

Comments

@jkowalleck
Copy link
Member

jkowalleck commented Jun 16, 2023

Please do not reuse propertyType for "environmentVar".
The annotations from propertyType do not match the case here.

better define a dedicated (abstract) key-value pair element type:

<xs:complexType name="KeyValuePair">
    <xs:simpleContent>
        <xs:extension base="xs:string">
            <xs:attribute name="name" use="required">
                <xs:annotation><xs:documentation>The name of the env var</xs:documentation></xs:annotation>  
                <xs:simpleType>
                  <xs:restriction base="xs:token">
                    <xs:minLength value="1" />
                  </xs:restriction>
                </xs:simpleType>
            </xs:attribute>
        </xs:extension>
    </xs:simpleContent>
</xs:complexType>

(PS: this "KeyValuePair" is not identical to current implementation of "propertyType")

and use it here

<xs:element name="environmentVar" type="bom:KeyValuePair" />

Originally posted by @jkowalleck in #222 (comment)

@jkowalleck
Copy link
Member Author

jkowalleck commented Jun 16, 2023

@stevespringett i do not know where to put it.
milestone 1.6? 2.0?
depends on the actual implementation, this could be a breaking change, or it could be a widening/expanding of existing types.

it could be done via #249

@jkowalleck jkowalleck changed the title Please do not reuse propertyType here. Please do not reuse propertyType for "environmentVar " Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant