Add Subscribe overload with riseOnSubscription parameter #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Cysharp#215 Add `Subscribe(Observer<T> observer, bool riseOnSubscription = true)` overload to `ReactiveProperty<T>` class. * Add a new `Subscribe` method overload with `riseOnSubscription` parameter to `ReactiveProperty<T>` class in `src/R3/ReactiveProperty.cs`. * Update `SubscribeCore` method in `ReactiveProperty<T>` class to conditionally call `observer.OnNext(currentValue)` based on `riseOnSubscription` parameter. * Add new `Subscribe` method overloads with `riseOnSubscription` parameter to `ObservableSubscribeExtensions` class in `src/R3/ObservableSubscribeExtensions.cs`. * Add unit tests for the new `Subscribe` method overload with `riseOnSubscription` parameter in `ReactiveProperty<T>` class in `tests/R3.Tests/ReactivePropertyTest.cs`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Cysharp/R3/issues/215?shareId=XXXX-XXXX-XXXX-XXXX).
|
We cannot accept AI-generated code unless you can explain the code yourself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215
Add
Subscribe(Observer<T> observer, bool riseOnSubscription = true)overload toReactiveProperty<T>class.Subscribemethod overload withriseOnSubscriptionparameter toReactiveProperty<T>class insrc/R3/ReactiveProperty.cs.SubscribeCoremethod inReactiveProperty<T>class to conditionally callobserver.OnNext(currentValue)based onriseOnSubscriptionparameter.Subscribemethod overloads withriseOnSubscriptionparameter toObservableSubscribeExtensionsclass insrc/R3/ObservableSubscribeExtensions.cs.Subscribemethod overload withriseOnSubscriptionparameter inReactiveProperty<T>class intests/R3.Tests/ReactivePropertyTest.cs.For more details, open the Copilot Workspace session.