Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject proposals when they can't pass #169

Closed
JakeHartnell opened this issue Feb 7, 2022 · 1 comment
Closed

Reject proposals when they can't pass #169

JakeHartnell opened this issue Feb 7, 2022 · 1 comment
Assignees
@Callum-A

Comments

@JakeHartnell
Copy link
Member

JakeHartnell commented Feb 7, 2022 •
edited
Loading

Currently, cw3-dao and cw3-multisig only show proposals as rejected when time has run out. This is because they really only pay attention to the yes votes.

From the README:

Before the proposal has expired, any voter with non-zero weight can add their vote. Only "Yes" votes are tallied. If enough "Yes" votes were submitted before the proposal expiration date, the status is set to "Passed".

We should also tally "No" votes, and update the proposal status if it reaches a sufficient amount to prevent the proposal from passing.
@JakeHartnell JakeHartnell added this to the v2 milestone Feb 7, 2022
@Callum-A Callum-A mentioned this issue Feb 17, 2022
Merged
@maurolacy maurolacy mentioned this issue Feb 21, 2022
Closed
@Callum-A Callum-A self-assigned this Feb 24, 2022
@JakeHartnell
Copy link
Member Author

Closed with #181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Callum-A Callum-A

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JakeHartnell @Callum-A