Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how best to expose errors to DAOs #11

Closed
0xekez opened this issue Mar 25, 2023 · 3 comments
Closed

Investigate how best to expose errors to DAOs #11

0xekez opened this issue Mar 25, 2023 · 3 comments
Labels

Comments

@0xekez
Copy link
Contributor

0xekez commented Mar 25, 2023

If a DAO executes a message via polytone, we should provide the same proposal close-on-execution-failure option as we do for normal messages. We should also make this error event visible to the DAO DAO indexer via queries.

@0xekez 0xekez added the feature label Mar 27, 2023
@0xekez
Copy link
Contributor Author

0xekez commented Mar 28, 2023

there is leeway in how we design this. i don't think we are married to returning an unlabeled binary blob. developer UX is most important here.

also, two notes from conversation with larry and ethan

  1. the error string is not stored in the merkle tree, so the error fields in our callbacks will be the classic "codespace wasm: 5".
  2. the attributes of the CosmWasm reply only contain attributes from x/wasm as they had to remove the rest due the SDK being non-deterministic.

@Art3miX
Copy link
Collaborator

Art3miX commented Apr 1, 2023

We should return what we can and need, this ensures that if updates are made to the returned data, we pretty much get it for "free" (closest to free we can get them).
I think #19 is doing it right, its feels like you get a direct response from your sent msgs.

@0xekez
Copy link
Contributor Author

0xekez commented Apr 7, 2023

closing for #19

@0xekez 0xekez closed this as completed Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants