You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 10, 2020. It is now read-only.
I'm currently using the fixes/1.2 branch for better Android support, but just noticed a bug while testing Android notifications. It seems the bug persists it both branches, not only fixes/1.2 but also dev-master.
When sending an GCM notifications via the console commands the messages get a new status MESSAGE_STATUS_SENDING. After the messages have been succesfully sent by e.g. \DABSquared\PushNotificationsBundle\Service\OS\AndroidGCMNotification::send the messages never get a new status set, like MESSAGE_STATUS_SENT.
Also devices never get set active or unactive. The whole function is not complete.
To negate this problem, and the only way to get proper statusses for messages or devices is by using the documented $this->container->get('dab_push_notifications')->send($message);.
If messages are saved via custom code e.g. $messageManager->saveMessage($message);, you have to use the aforementioned command after message creation/saving, and cannot use the console command to send out in bulk.
In any case, i like to end with a big thanks to the contributers for creating a fine bundle that is easy customizable. Just wanted to point out the unfinished code when using console commands.
Kind regards, Roy Jacobs
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi there,
I'm currently using the
fixes/1.2
branch for better Android support, but just noticed a bug while testing Android notifications. It seems the bug persists it both branches, not onlyfixes/1.2
but alsodev-master
.When sending an GCM notifications via the console commands the messages get a new status
MESSAGE_STATUS_SENDING
. After the messages have been succesfully sent by e.g.\DABSquared\PushNotificationsBundle\Service\OS\AndroidGCMNotification::send
the messages never get a new status set, likeMESSAGE_STATUS_SENT
.Also devices never get set active or unactive. The whole function is not complete.
To negate this problem, and the only way to get proper statusses for messages or devices is by using the documented
$this->container->get('dab_push_notifications')->send($message);
.If messages are saved via custom code e.g.
$messageManager->saveMessage($message);
, you have to use the aforementioned command after message creation/saving, and cannot use the console command to send out in bulk.In any case, i like to end with a big thanks to the contributers for creating a fine bundle that is easy customizable. Just wanted to point out the unfinished code when using console commands.
Kind regards, Roy Jacobs
The text was updated successfully, but these errors were encountered: