Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the single value column workaround #57

Closed
csala opened this issue Sep 5, 2018 · 0 comments
Closed

Review the single value column workaround #57

csala opened this issue Sep 5, 2018 · 0 comments
Labels
internal The issue doesn't change the API or functionality
Milestone
0.2.2

Comments

@csala
Copy link
Contributor

csala commented Sep 5, 2018

If the fit data has only one value, hence the std is 0, the current code has a workaround to avoid crashing later on when trying to crash:

https://github.com/DAI-Lab/Copulas/blob/f27d86d50db8e8e94c43bf6c0f17f650bffdd6ce/copulas/univariate/gaussian.py#L45

Wouldn't it be better to capture and implement this exceptional situation by just making all samples constant, equal to the mean?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
0.2.2
Development

No branches or pull requests
2 participants
@csala @ManuelAlvarezC