Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle errors correctly when reading files in StatsRestartReader #1213

Closed
cz4rs opened this issue Jan 13, 2021 · 1 comment
Closed

handle errors correctly when reading files in StatsRestartReader #1213

cz4rs opened this issue Jan 13, 2021 · 1 comment
Labels
pri: low type: bug

Comments

@cz4rs
Copy link
Contributor

cz4rs commented Jan 13, 2021

Describe the bug
Warnings related to unused return values from fscanf calls in stats_restart_reader.cc were silenced, but the code still lacks correct logging and error handling.

Expected behavior
Handle malformed records / files correctly. Make sure to unit test these edge cases.
@cz4rs cz4rs mentioned this issue Jan 13, 2021
Merged
@lifflander
Copy link
Collaborator

This is fixed due to the new json LB stats. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pri: low type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lifflander @cz4rs