Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cmake options to force vt to use external libraries #1848

Open
nmm0 opened this issue Jun 9, 2022 · 1 comment
Open

add cmake options to force vt to use external libraries #1848

nmm0 opened this issue Jun 9, 2022 · 1 comment
Assignees

Comments

@nmm0
Copy link
Collaborator

nmm0 commented Jun 9, 2022

What Needs to be Done?

Package managers typically do not work well with bundled libraries, potentially because of version conflicts, build efficiency, and so on. We should provide a set of flags to force the use of find_package for some external libraries. These should be off by default, but potentially enabled in the spack build.

It's worth noting we may have to figure out our namespacing issue since we currently bundle libs ilke fmt under fmt::vt

@cz4rs
Copy link
Contributor

cz4rs commented Jun 14, 2022

As discussed today, this would probably mean reverting all the renaming fixes and having "vanilla" fmt copy again (which I think is nice).
In theory we could even use find_package by default and resort to CMAKE_DISABLE_FIND_PACKAGE_... for forcing the embedded copy.

Anyways, since this is a low priority for now, we can also wait for C++20 and std::format adoption 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants