Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose apps on multiple domains #14

Open
adamtulinius opened this issue May 30, 2017 · 2 comments
Open

expose apps on multiple domains #14

adamtulinius opened this issue May 30, 2017 · 2 comments
Assignees
Milestone

Comments

@adamtulinius
Copy link
Contributor

adamtulinius commented May 30, 2017

It should be possible to

  1. specify multiple domains in the marathon label
  2. expose everything with and without a FQDN (i.e. bar.foo.example.com as well as bar.foo)

@srhb

@adamtulinius adamtulinius self-assigned this May 30, 2017
@adamtulinius adamtulinius added this to the 1.0 milestone May 30, 2017
@adamtulinius
Copy link
Contributor Author

adamtulinius commented May 30, 2017

Thoughts: (2) Could be implemented by always stripping a suffix from the hostname, or adding a suffix to the hostname when missing.

If always adding a suffix, all domains in labels could be written more succinctly as the short version of the hostname, but this might make users rely on this feature.
On the other hand stripping the postfix might make this more of a "oh, nice it worked despite not typing the FQDN into my browser" sort of thing.

@srhb
Copy link
Contributor

srhb commented May 30, 2017

I absolutely agree that (1) would be nice to have; it would remove a lot of my boilerplate. I'm skeptical about (2), however, as I think the "path of least effort" during debugging is to look for exact matches, not label values that might have transformed to include or exclude parts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants