Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum from str #1

Open
pickfire opened this issue Jun 22, 2019 · 4 comments
Open

Enum from str #1

pickfire opened this issue Jun 22, 2019 · 4 comments

Comments

@pickfire
Copy link

https://github.com/1aim/rust-phonenumber/blob/master/src/country.rs#L328 might seem to be a nice use case.

As well, what about AsRef<str>?

@DCjanus
Copy link
Owner

DCjanus commented Jun 22, 2019

@pickfire
Copy link
Author

Oh, I just noticed that. By the way, I also found out about https://lib.rs/crates/strum, are these crates related to that?

@DCjanus
Copy link
Owner

DCjanus commented Jun 22, 2019

It is recommended to use strum

@pickfire
Copy link
Author

Should we add a link to strum in the README? I wasn't aware of strum while I was checking out this crate, maybe it might help to at least let other knows about strum and this is like a striped down version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants