Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing explicit time integrators with SciML #6

Open
SCiarella opened this issue Nov 22, 2023 · 4 comments
Open

Consider replacing explicit time integrators with SciML #6

SCiarella opened this issue Nov 22, 2023 · 4 comments
Assignees

Comments

@SCiarella
Copy link
Member

No description provided.

@SCiarella SCiarella added this to Main Nov 22, 2023
@SCiarella SCiarella converted this from a draft issue Nov 22, 2023
@SCiarella
Copy link
Member Author

The problem with this is how to include the pressure term:

  1. solving the coupled Poisson equation (algebraic ODE)
  2. replace the pressure term (it requires matrix inversion, which makes it not sparse anymore)

@SCiarella
Copy link
Member Author

There is another problem with the spectral space in SciML:
the non-linear term $\hat{u u^T}$ is usually computed as multiplication->FFT, so this requires the solver to do IFFT at each step to compute this term, but this is NOT the standard behavior of SciML.

@SCiarella SCiarella moved this from Todo to In Progress in Main Nov 29, 2023
@SCiarella SCiarella self-assigned this Nov 29, 2023
@SCiarella SCiarella moved this from In Progress to Done in Main Dec 19, 2023
@luisaforozco
Copy link

Do not know if is the right place but there is a SciMLStyle which are basically guidelines for code writing in Julia. I think is a good place to start when starting to integrate SciML in Syver's and Toby's code.

@PabRod
Copy link
Contributor

PabRod commented Feb 15, 2024

Do not know if is the right place but there is a SciMLStyle which are basically guidelines for code writing in Julia. I think is a good place to start when starting to integrate SciML in Syver's and Toby's code.

Looks pretty relevant. Also, see this thread about parameter management in our brand new Julia Teams channel (private).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants