Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homogenization float32 -> float64 (default) #24

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Homogenization float32 -> float64 (default) #24

merged 1 commit into from
Mar 26, 2024

Conversation

luisaforozco
Copy link
Contributor

@luisaforozco luisaforozco commented Mar 25, 2024 •
edited
Loading

Context

Issue #15

In this PR all the float32 were converted to float64 (default float-point type of Julia).
At least for the moment we can keep it like this and see in the future if we need to make some changes due to memory issues.

I've run the examples.
Closes #15

@luisaforozco luisaforozco requested a review from APJansen March 25, 2024 13:22
@APJansen
Copy link
Contributor

Two small comments, otherwise it looks good to merge:

  • I still see some f0's in the GrayScott example (and GrayScott_alternative).
  • Did you compare the timings? It didn't get noticably slower?

@luisaforozco
Copy link
Contributor Author

  • TODO_02.04-GrayScott_alternative.jl is still in TODO. So I haven't touched it.
  • Not getting noticeable slower. Also my laptop has a lot of memory and the examples are rather small.

APJansen
APJansen approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@APJansen APJansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just make sure Simone is aware then

@luisaforozco luisaforozco merged commit 94870fc into main Mar 26, 2024
2 checks passed
@luisaforozco luisaforozco deleted the example_float32 branch March 26, 2024 15:09
v1kko pushed a commit that referenced this pull request Jan 16, 2025
@luisaforozco
Convert float32 -> float64 (default) (#24)
7361a7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@APJansen APJansen APJansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

float32 vs float 64 homogeneity
2 participants
@luisaforozco @APJansen