Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make create_f_CNODE also return the NODE #36

Closed
SCiarella opened this issue May 21, 2024 · 3 comments
Closed

Make create_f_CNODE also return the NODE #36

SCiarella opened this issue May 21, 2024 · 3 comments
Assignees

Comments

@SCiarella
Copy link
Member

In this way there is no need for the user to call directly NeuralODE(*).

Then, create_f_CNODE will need to receive as input also the parameters that will be used for the solution, like t_range, algorithm, ecc..

@luisaforozco luisaforozco self-assigned this May 21, 2024
@luisaforozco
Copy link
Contributor

If the force is needed, for example to create the loss, one could get it via: my_neuralODE.model

@luisaforozco
Copy link
Contributor

This is implemented now in branch wrap_neuralODE.

However, I see that there are some sort of memory leaks (many allocations) that were not there before. We need to first understand what is going on before merging that work.

@luisaforozco
Copy link
Contributor

That PR was closed. The branch should also eventually be removed but I leave it in case we want to look back at something. I close this issue because this is no longer relevant, we changed completely the way of writting the forces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants