Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise sign-in methods into optional plugins #23

Open
brendanarnold opened this issue Dec 9, 2022 · 1 comment
Open

Generalise sign-in methods into optional plugins #23

brendanarnold opened this issue Dec 9, 2022 · 1 comment

Comments

@brendanarnold
Copy link
Collaborator

brendanarnold commented Dec 9, 2022

Twitter and Facebook are hardcoded into the pol.is codebase as the only 3rd party sign-in methods. These should be abstracted out into plugins so that they can be removed entirely from a deployment.

  • Simplifies cookie policy
  • Untangles 3rd party code from codebase
  • Better architecture for other sign-in integrations such as GovUK Sign-In
@patcon
Copy link

patcon commented Dec 10, 2022

Love this! A generalized oauth2 flow might be a good start to work out how best to do this 🤔

Potential todo: cross-ref related issues in upstream polis repo, as this has def been discussed.

@brendanarnold brendanarnold changed the title Abstract Twitter and Facebook sign-in into optional plugins Generalise sign-in methods into optional plugins Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants