-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EXPORT definition might collide easily #19
Comments
Sounds good to me - probably something I should have thought about in #17 |
now have also a commit for this issue in PR #4 different from my own suggestion i renamed EXPORT to CLSOCKET_API, |
Looks awesome, thanks for the fix! Saves me from having to address #17 (comment). That was on my to-do list, so I'll take a closer look at #4, hopefully soon. |
is defined in Host.h include from other public headers (SimpleSocket.h), with guard
#ifdef _MSC_VER
.however this definition might collide easily with user code using CLsocket.
i'd suggest to rename EXPORT into CLSOCKET_EXPORT ..
[ and possibly make this definition only when having an additional private definition in CMakeLists.txt, e.g. when compiling the shared library ]
The text was updated successfully, but these errors were encountered: