Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to Teldrassil quest 28723 - nightelf only #1777

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Change to Teldrassil quest 28723 - nightelf only #1777

merged 5 commits into from
Sep 12, 2024

Conversation

Rotte
Copy link
Contributor

@Rotte Rotte commented Sep 7, 2024

No description provided.

@Darkal31
Copy link
Collaborator

Darkal31 commented Sep 7, 2024

I have completed this quest with Human and Draenei too. It should be available to any race.

@Rotte
Copy link
Contributor Author

Rotte commented Sep 7, 2024

Well in Cata it is not available for all races? Wowhead also lists it as Nightelf only. Is it changed in Retail to be all?

@Rotte
Copy link
Contributor Author

Rotte commented Sep 7, 2024

Also only says Nightelf on wowhead for retail - and not existing in Classic - like it has a timeline add of 4.0.3

@Rotte
Copy link
Contributor Author

Rotte commented Sep 7, 2024

image
image
This turns out false, and she has no quest for me. I have done the prerequisite (am a gnome), but no quest available. Its true for at lot of the starter-quests in Shadowglen.

@Eremeir
Copy link
Member

Eremeir commented Sep 7, 2024

I just did this quest 5 minutes ago on a Worgen. Perhaps there is an additional source quest?

@Darkal31
Copy link
Collaborator

Darkal31 commented Sep 7, 2024

Based on wowhead comment, the quest was changed to all races in 7.2.5. So this just needs #if statements to account for that in the code.

@Rotte
Update Teldrassil.lua
f709184 
Now the races should be correct for the quest
Eremeir
Eremeir requested changes Sep 8, 2024
View reviewed changes
Copy link
Member

@Eremeir Eremeir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-- #if AFTER LEGION needs to be -- #if AFTER 7.2.5

@Rotte
Update Teldrassil.lua
9c0d16e 
Changed after legion to after 7.2.5
@Rotte
Copy link
Contributor Author

Rotte commented Sep 12, 2024

I changed it.

@Eremeir Eremeir merged commit 875a525 into ATTWoWAddon:master Sep 12, 2024
@ShadowBrooks
Copy link
Member

Just FYI we would prefer seeing the if statements inside the brackets in the future to not duplicate "races" etc.
image

Exodius pushed a commit to Exodius/AllTheThings that referenced this pull request Nov 7, 2024
@Rotte
Change to Teldrassil quest 28723 - nightelf only (ATTWoWAddon#1777)
94487c9 
Changed Quest 28723 - Priestess of the Moon to be Nightelf only unless after 7.2.5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eremeir Eremeir Eremeir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rotte @Darkal31 @Eremeir @ShadowBrooks