Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[localization] Migrate classic locales file to default locale file #1787

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[localization] Migrate classic locales file to default locale file #1787

merged 1 commit into from
Sep 16, 2024

Conversation

NORPG
Copy link
Member

@NORPG NORPG commented Sep 16, 2024

Phase 1

@NORPG
Copy link
Member Author

NORPG commented Sep 16, 2024 •
edited
Loading

Migrate a part of classic/locales.lua to Locales/Default Locales.lua.
But I didn't have Subscription, and I haven’t tested whether the classic version of ATT is functioning properly.
Volunteers are needed for testing.

@NORPG NORPG marked this pull request as draft September 16, 2024 12:36
@NORPG NORPG marked this pull request as ready for review September 16, 2024 14:03
@DFortun81 DFortun81 merged commit e641a7c into ATTWoWAddon:master Sep 16, 2024
@NORPG NORPG mentioned this pull request Sep 26, 2024
Merged
Exodius pushed a commit to Exodius/AllTheThings that referenced this pull request Nov 7, 2024
@DFortun81
Merge pull request ATTWoWAddon#1787 from NORPG/master
7c172c5 
[localization] Migrate classic locales file to default locale file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DFortun81 DFortun81 DFortun81 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NORPG @DFortun81