Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No validation error is shown when not entering other researchers #730

Open
tijmenbaarda opened this issue Oct 23, 2024 · 3 comments · May be fixed by #754
Open

No validation error is shown when not entering other researchers #730

tijmenbaarda opened this issue Oct 23, 2024 · 3 comments · May be fixed by #754
Labels

Comments

@tijmenbaarda
Copy link

tijmenbaarda commented Oct 23, 2024

Path: /proposals/other_researchers/
Occurred during practice application.

When selecting "yes" but not entering other researchers, no validation error is shown but the user cannot continue.

The same happens when I do add another researcher, but when I also remove myself.

@tijmenbaarda
Copy link
Author

Probably related to this, when first selecting "yes" and then "no" to the first question, it seems that the (now invisible) researcher list is still evaluated, so the same problem as above occurs.

@miggol
Copy link
Contributor

miggol commented Oct 31, 2024

Can be grouped together with #728

@EdoStorm96
Copy link
Contributor

It seems that the widget we are using for this (SearchableSelectWidget), does not display errors ... This also happens with the supervisor field. I've made an issue in the DSC for this.

For now, the fix is, I would say, to display these error on another field.

@EdoStorm96 EdoStorm96 linked a pull request Nov 14, 2024 that will close this issue
@EdoStorm96 EdoStorm96 linked a pull request Nov 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants