Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SI calculation error #137

Closed
daniel-caichac-DHI opened this issue Sep 27, 2022 · 4 comments · Fixed by #142
Closed

SI calculation error #137

daniel-caichac-DHI opened this issue Sep 27, 2022 · 4 comments · Fixed by #142

Comments

@daniel-caichac-DHI
Copy link
Collaborator

Hi all,
I think that here might be an error in the calculation of the scatter index. I have used another script and I got different results, so I decided to check and I think that the mean value is not being taken into account somewhere in the equation. I found that SI can also be interpreted as
image
with Xmean = Mean of observations
I reviewed a few comparer objects and the other script checks out but I don't get it in fmskill. I am computing SI with this formula
image
but the one in FMSkill is not taking into account 1/N

@daniel-caichac-DHI daniel-caichac-DHI changed the title SI calculation SI calculation error Sep 27, 2022
@ecomodeller
Copy link
Member

Well... Scatter index according to for instance Mentaschi et al, 2013, Problems in RMSE-based wave model validations is defined like this:
image

Which is what we use in the fmskill at the moment:
image

I suppose there are several slightly different definitions for scatter index.

fmskill is pretty flexible in using custom metrics so you can use your definition or we could add it with a different name or change the definition of the existing one if we are really sure that is the commonly used definition.

@jsmariegaard
Copy link
Member

The implemented formula for SI can be seen here: https://dhi.github.io/fmskill/api.html#fmskill.metrics.scatter_index - what is the best reference you have for the SI?

@daniel-caichac-DHI
Copy link
Collaborator Author

Alright no problem then, I thought it was an error but I agree with Henrik that there might be several slightly different definitions (The difference I got between my formula and the one implemented was ~0.02 or 0.01 so I will just close this post

@jsmariegaard
Copy link
Member

Let's leave it open until we decide what to do. @ecomodeller and I are leaning towards changing the definition to be consistent with your other tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants