Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PilotCSToJSONSnchronizer is not thread safe #4697

Closed
chaen opened this issue Jul 28, 2020 · 5 comments
Closed

PilotCSToJSONSnchronizer is not thread safe #4697

chaen opened this issue Jul 28, 2020 · 5 comments
Assignees
Milestone

Comments

@chaen
Copy link
Contributor

chaen commented Jul 28, 2020

We observed a race condition where the commitNewData method from the CS was called twice, in a short amount of time, the first one being still ongoing when the second one started. Of course, that does not work.

Two options:

One more option, and probably my favourite one: go back to an agent doing the work, instead of triggering from the CS. Much less error prone...

Opinions ?

@fstagni
Copy link
Contributor

fstagni commented Jul 29, 2020

Locking the commitNewData would probably be a good idea independently of this issue. @atsareg what do you think?

@chaen
Copy link
Contributor Author

chaen commented Aug 6, 2020

We need to move on with this. If no objection/reply, I'll do it next week

@fstagni
Copy link
Contributor

fstagni commented Aug 6, 2020

Which solution?

@fstagni fstagni added this to the v7r1 milestone Oct 6, 2020
@fstagni
Copy link
Contributor

fstagni commented Dec 16, 2020

I coded first stub here: integration...fstagni:v7r2-useAgentForCSPilot

Please have a look.

@fstagni
Copy link
Contributor

fstagni commented Jan 12, 2021

I believe this can be closed now.

@fstagni fstagni closed this as completed Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants