Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Error when a link has more than 500 tracks #32

Closed
urbancosmos opened this issue May 23, 2023 · 2 comments
Closed

[Bug] Error when a link has more than 500 tracks #32

urbancosmos opened this issue May 23, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@urbancosmos
Copy link

🐞 Bug Report

Describe the bug

  • When I tried to download a link that includes more than 500 tracks, the program only download the first 500 tracks, and then stops with this error:

Album Download Task ERROR.
System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
at System.ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument argument, ExceptionResource resource)
at QobuzDownloaderX.Shared.DownloadManager.d__29.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at QobuzDownloaderX.Shared.DownloadManager.d__35.MoveNext()


Is this a regression?

NO

To Reproduce


Expected behaviour

  • To download all the tracks that a links contains.

Screenshots


Additional context

@urbancosmos urbancosmos changed the title [Bug] [Bug] Error when a link has more than 500 tracks May 23, 2023
@DJDoubleD DJDoubleD added the bug Something isn't working label May 23, 2023
@DJDoubleD DJDoubleD self-assigned this May 23, 2023
@DJDoubleD
Copy link
Owner

The fixed limit of 500 items per link is currently a know limitation (that was also present in the original QBDLX) 1 API call only returns 500 items and I haven't implemented pagination to get the next 500 items from the API (until all items are fetched).
But even though the fixed limit of 500 items in known, there shouldn't be an error at the end.
Can you please include the link for which you encountered the error in this issue so I can investigate.

@urbancosmos
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants