Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Please could you add this Tags? MEDIA, RELEASEDATE & URL #41

Closed
rodfeli opened this issue Aug 14, 2023 · 11 comments
Closed
Assignees
Labels
Enhancement Enhancement of existing functionality

Comments

@rodfeli
Copy link

rodfeli commented Aug 14, 2023

🚀 Enhancement Request

Is your enhancement request related to a problem? Please describe.

Would be nice you include this missing extended tags MEDIA, RELEASEDATE, URL


Describe the solution you'd like

Would be nice you include this missing extended tags. I think there are available from Qobuz:

  • MEDIA (generally is "Digital Media")
  • RELEASEDATE in the form of "YYYY-MM-DD" (I think it is great replacement for the actual "ORIGINALRELEASETIME" tag)
  • URL (The link provided in Qobuz Link to snatch the album) - Maybe this one added as choice in the Tags to Save
@MikevE1995
Copy link

I would love to have the release date with not just the year

@rodfeli
Copy link
Author

rodfeli commented Aug 15, 2023

I would love to have the release date with not just the year

Yes, the new release broken that. Before that the release date was fine and equal to the YEAR tag. I think the correct is mantain the YEAR tag as YYYY and the extended RELEASEDATE tag like YYYY-MM-YY as I mention in my Enhancement request.

@MikevE1995
Copy link

for me it currently is YYYY for both the release date and year tags

@rodfeli rodfeli changed the title [Enhancement] Please could you add this Tags? MEDIA, RELEASE DATE & URL [Enhancement] Please could you add this Tags? MEDIA, RELEASEDATE & URL Aug 15, 2023
@rodfeli
Copy link
Author

rodfeli commented Aug 15, 2023

Yes,
the year in format YYYY is in both tags YEAR & ORIGINALRELEASETIME...

@DJDoubleD
Copy link
Owner

For my own reference:

  • RELEASEDATE
    The whole dates discussion was handled in [Enhancement] Release date tag only shows the year #42
    So this tag won't be added.

  • MEDIA (generally is "Digital Media")
    This seems to come directly from MusicBrainz Picard's mapping
    In the official Vorbis Comment Specification, this field isn't listed and in the officially proposed update, the field SOURCEMEDIA is proposed.
    Given the fact that the naming is unclear, neither MediaInfo nor MP3Tag seem to use any of these tags and the value would be a hard coded 'Digital Media", I don't really see the added value to clutter the embedded tags with this.
    I'll leave this one up to users to add in bulk afterwards with tools like MusicBrainz Picard or MP3Tag if they so wish.
    So this tag won't be added.

  • URL
    This seems like a useful tag to add, even though it's not listed anywhere as an official Vorbis Comment field, several players and tools I've tested seem to recognize and use the URL field for FLAC files.
    For MP3 files, I think I'll probably use the WCOM ID3 v2.4 Frame.
    When I get to it, I'll add this tag to the options so the users can decide if they want it written to the files or not.
    The link used will be the album URL that the Qobuz API returns for each track/album. This url links to the Album in the Qobuz store and seems most consistent.

@DJDoubleD DJDoubleD self-assigned this Aug 24, 2023
@DJDoubleD DJDoubleD added the Enhancement Enhancement of existing functionality label Aug 24, 2023
@rodfeli
Copy link
Author

rodfeli commented Sep 1, 2023

For my own reference:

  • RELEASEDATE
    The whole dates discussion was handled in [Enhancement] Release date tag only shows the year #42
    So this tag won't be added.
  • MEDIA (generally is "Digital Media")
    This seems to come directly from MusicBrainz Picard's mapping
    In the official Vorbis Comment Specification, this field isn't listed and in the officially proposed update, the field SOURCEMEDIA is proposed.
    Given the fact that the naming is unclear, neither MediaInfo nor MP3Tag seem to use any of these tags and the value would be a hard coded 'Digital Media", I don't really see the added value to clutter the embedded tags with this.
    I'll leave this one up to users to add in bulk afterwards with tools like MusicBrainz Picard or MP3Tag if they so wish.
    So this tag won't be added.
  • URL
    This seems like a useful tag to add, even though it's not listed anywhere as an official Vorbis Comment field, several players and tools I've tested seem to recognize and use the URL field for FLAC files.
    For MP3 files, I think I'll probably use the WCOM ID3 v2.4 Frame.
    When I get to it, I'll add this tag to the options so the users can decide if they want it written to the files or not.
    The link used will be the album URL that the Qobuz API returns for each track/album. This url links to the Album in the Qobuz store and seems most consistent.

Hi DJDoubleD,

It seems the ReleaseDate is not saved in the tag DATE, it is saved as a double YEAR tag (the year is also saved in this tag)

Thanks for adding the URL tag, improve the download speed and a great update for this gorgeous tool!!!

@MikevE1995
Copy link

For me the FLAC file release dates are correctly saved in the tag Date and Year

@rodfeli
Copy link
Author

rodfeli commented Sep 1, 2023

For me the FLAC file release dates are correctly saved in the tag Date and Year

Not for me. I even deleted the configuration and reconfigured it in case any value in settings.json had been wrong

https://i.imgur.com/6dRVJLh.jpg

@DJDoubleD
Copy link
Owner

For me the FLAC file release dates are correctly saved in the tag Date and Year

Not for me. I even deleted the configuration and reconfigured it in case any value in settings.json had been wrong

https://i.imgur.com/6dRVJLh.jpg

Most likely you are checking the tags with a program that just combines the YEAR and DATE tags and displays then as 1 field.
If you want completely correct info from a file, use something like exiftool to check all properties and tags as they are actually present in the file.
For me, the YEAR and DATE tags are correct:
image

If you managed to download a FLAC file with both tags enabled and don't get separate Year and Date tags in the output from exiftool, I would be interested in the link and settings used. But I strongly suspect you will also get separate tags in the output from your files.

@rodfeli
Copy link
Author

rodfeli commented Sep 1, 2023

Yes! You are right!
I really don't know if I added these lines a long time ago or it comes like this... but here is the problem.

https://i.imgur.com/LqrOJDR.jpg

All is fine DjD!

Thanks again for your great work!

@orbittwz
Copy link

orbittwz commented Sep 4, 2023

this issue thread helped me understand the Year vorbis tag when using the program.
I was having issues when selecting the Release Year option instead of Release Date option...
The Year vorbis tag was showing YEAR all in upper case, and was considered custom field by some programs.
I chose Release Date option and it was fine, when running Exiftool the Date vorbis tag is used now, and it's considered not custom to most programs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Enhancement of existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants