Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept for "compressed master ref" subset. #17

Open
vinjana opened this issue Jan 30, 2024 · 0 comments
Open

Concept for "compressed master ref" subset. #17

vinjana opened this issue Jan 30, 2024 · 0 comments

Comments

@vinjana
Copy link
Member

vinjana commented Jan 30, 2024

Currently, the Hg37ChrConverter (legacy) and the GenericChrConverter encapsulate some of the handling of the global chromosome index space and the compressed-master ref subspace. Still, the client code has problems:

  1. Client code uses use using declarations of unsigned long to model chromosome indices. This means, there is no type checking and a confusion of functions for one set with indices of the other set is always imminent.
  2. The client code actually has to deal with this discrimination.
  3. The chromosome converters are complex, but it is not clear, whether these two sets are really necessary to be handled as separate index sets for reource reasons (memory/CPU), or not.

To-Do

  1. Clarify what is the semantic value of the compressed master refs for the SOPHIA algorithm? Is the concept actually needed?
  2. If it is needed, try to encapsulate all mapping logic in a way that client code has not to deal much with it, in particular, if possible not on a line-by-line level. E.g. strongy typing may be sufficient (e.g. 2 classes of indices, or a class that has a "global" and a "compressedMref" view, or a hybrid class that incorporates the mapping between the two domains).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant