-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TinyMCE loads content.min.css once for each text area #1285
Comments
related to #1298 |
Did some initial experimentation with the above recommendations. Setting the 'mode' on the Tinymce init method didn't seem to have any affect. |
I dug into this problem while trying to fix #1365. Tinymce loads the content.min.css asynchronously for each instance created and since each textarea got associated a new iframe for tinymce, there is no way to prevent loading multiple times the content.min.css (unless inline mode is used, which we don't want). In order to speed up the page rendering, we should load things on demand (as @briri suggested) and therefore tinymce instances would be loaded incrementally when the user requests a specific area. |
Any update on this issue? |
Hi @mesterjagels, no we have not addressed this issue yet. We will be investigating the new Rails 6 ActionText as a replacement for Tinymce along with a larger redesign of the way the forms are generated/loaded. We did update the 'Write Plan' page so that the Tinymce text areas load when the user expands one of the accordion sections which seems to have dramatically improved performance. It was originally loading them all at once which, depending on the number of sections/questions for the template was extremely slow to load. |
Needs some investigation if this issue is still relevant |
Please improve this behavior! This will cause the loading bug when using the slow network! Steps: Then, navigate back to page1, the editor will not load forever! It will be always blank!!! What a horrible bug! |
Expected behaviour:
content.min.css
loaded onceActual behaviour:
content.min.css
loaded x times for x text areas which is actively slowing down our page loads for large templates (it also gives the impression that you can't click on accordions to edit)Steps to reproduce: edit a plan with multiple questions
Proposed solution here perhaps?
The text was updated successfully, but these errors were encountered: