Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose a documentation standard throughout the repo #1674

Open
Bodacious opened this issue Jul 5, 2018 · 3 comments
Open

Choose a documentation standard throughout the repo #1674

Bodacious opened this issue Jul 5, 2018 · 3 comments
Labels
convention Discuss/agree best practices for all contributors low-priority suggestion

Comments

@Bodacious
Copy link
Contributor

Bodacious commented Jul 5, 2018

Most methods outside of controller actions should have some level of documentation to describe their purpose.

The Yard syntax has been used well on some of the code, but this has not been used consistenly across the whole codebase.

TomDoc is a lightweight documentation syntax for Ruby that is used by many notable teams including GitHub. TomDoc provides the same features as yard, but is easier to write (and is more likely to be written).

TomDoc can be parsed by Yard to create the same automatically generated HTML documentation for developer reference.

We should decide on one of these documentation syntaxes (or RDoc) and enforce their use throughout the whole application.

Pros:

  • Provides developers with a better explanation of the intended function of given code.
  • Offers a pseudo-type-casting to add additional clarity to the contract for a given piece of code

Cons:

  • Developers will have to learn whatever syntax is decided on.
@magdalenadrafiova
Copy link

@briri and @xsrust is still still relevant?

@briri
Copy link
Contributor

briri commented Jul 6, 2020

yes. this is something we need to do still. Can certainly wait until post Rails5 though

@benjaminfaure
Copy link
Contributor

We need to look into how the documentation is handled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
convention Discuss/agree best practices for all contributors low-priority suggestion
Projects
None yet
Development

No branches or pull requests

4 participants