Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key exchange fails on 'encap_cap_both' check when running SPDM 1.2 #2959

Open
Miritq opened this issue Jan 15, 2025 · 4 comments · May be fixed by #2960
Open

Key exchange fails on 'encap_cap_both' check when running SPDM 1.2 #2959

Miritq opened this issue Jan 15, 2025 · 4 comments · May be fixed by #2960
Labels
bug Something isn't working

Comments

@Miritq
Copy link

Miritq commented Jan 15, 2025

When running SPDM 1.2 even that encap_cap is deprecated in DMTF spec SPDM1.2:
Still there is a check for the responder and requester encap_cap capability values to be true (source/fw/tools/libspdm_emulator/src/library/spdm_requester_lib/libspdm_req_key_exchange.c) - what cause a failure in the flow, and it's wrong.
Need to add there a check what's the SPDM version that configured.
@steven-bellock steven-bellock added the bug Something isn't working label Jan 15, 2025
@steven-bellock
Copy link
Contributor

Yes, it looks like that was missed in #2471. Note that, as of SPDM 1.2.2 ENCAP_CAP is undeprecated, if that's a real word.

steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Jan 15, 2025
@steven-bellock
Fix ENCAP_CAP checks to accommodate SPDM 1.2
837c8e1 
Fix DMTF#2959.

Signed-off-by: Steven Bellock <sbellock@nvidia.com>
@steven-bellock steven-bellock linked a pull request Jan 15, 2025 that will close this issue
Open
steven-bellock added a commit to steven-bellock/libspdm that referenced this issue Jan 15, 2025
@steven-bellock
Fix ENCAP_CAP checks to accommodate SPDM 1.2
bf72cbc 
Fix DMTF#2959.

Signed-off-by: Steven Bellock <sbellock@nvidia.com>
@Miritq
Copy link
Author

Miritq commented Jan 20, 2025

hi,
is there any ETA for bugs fixing?

@steven-bellock
Copy link
Contributor

In general, no, but this issue has had a pull request in #2960.

@Miritq
Copy link
Author

Miritq commented Jan 20, 2025

yes I saw, thanks!
so for PRs - is there ETA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ENCAP_CAP checks to accommodate SPDM 1.2 steven-bellock/libspdm
2 participants
@steven-bellock @Miritq