Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement timezone fix for summarizing uv to dv #159

Open
lindsayplatt opened this issue Sep 26, 2022 · 0 comments
Open

Implement timezone fix for summarizing uv to dv #159

lindsayplatt opened this issue Sep 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@lindsayplatt
Copy link
Contributor

Similar to the groundwater visualization, summarizing UV values to DV likely has issues with timezones being different from the site's local timezone. See the fix implemented here and the reason why we probably haven't noticed it in this repo here.

Unfortunately, this likely extends to the historic data that we use in this repo, which is summarized from UV to DV in the national-flow-observations due to how we are summarizing UV to DV. I imagine there is minimal difference, since there would only be a shift of 6 values between days, especially for the historic values.

@lindsayplatt lindsayplatt added the enhancement New feature or request label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant