Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with last day in animation #47

Closed
lindsayplatt opened this issue Dec 22, 2021 · 5 comments
Closed

Fix issue with last day in animation #47

lindsayplatt opened this issue Dec 22, 2021 · 5 comments
Assignees

Comments

@lindsayplatt
Copy link
Contributor

lindsayplatt commented Dec 22, 2021

It appears like the last day of the animation is showing data for October 2, 2021. Need to figure out what is going on:

image

@lindsayplatt lindsayplatt self-assigned this Dec 22, 2021
@cnell-usgs
Copy link
Member

As a temporary fix, the animation freezes on the first frame rather than the last now.

@lindsayplatt
Copy link
Contributor Author

It was definitely an issue with timezones. I've got a fix and am building but this goes back to the historic data, too, so it is a bit big of a build (don't need to re-download, just re-average)!

@cnell-usgs
Copy link
Member

cnell-usgs commented Jan 10, 2022

This is an issue again now that the data has been updated. Here's how where it freezes:
image

I'm not sure why all the sites are turning orange at the end. This should be the same as the first day, because it rewinds, but it is not. And slightly before that, all of NJ turns orange while it is surrounded by blue.

The bar chart also is off on the last day.

@cnell-usgs
Copy link
Member

cnell-usgs commented Jan 10, 2022

year21 <- read_csv('3_visualize/out/gw-conditions-year21.csv')

## sites by day
year21 %>%
  pivot_longer(contains('gwl_'), names_to = 'site', values_to = 'daily_obs') %>%
  filter(!is.na(daily_obs)) %>%
  group_by(day_seq) %>%
  summarize(sites = length(unique(site))) %>%
  arrange(sites) 

Above produces this:
image

So around 50% of sites are missing, and it thinks there are 366 days rather than 365

@lindsayplatt
Copy link
Contributor Author

I think you are still seeing this because I've got the changes only on my fork still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants