Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combine all js files into one #366

Closed
lindsayplatt opened this issue Jun 7, 2018 · 4 comments
Closed

combine all js files into one #366

lindsayplatt opened this issue Jun 7, 2018 · 4 comments
Assignees
@lindsayplatt

Comments

@lindsayplatt
Copy link

lindsayplatt commented Jun 7, 2018 •
edited
Loading

No reason not to combine the d3 js file(s), and files that go into all.min.js into one big master minified js file.
@aappling-usgs
Copy link
Contributor

Cool! Why not? I thought we needed to inject build_map.js within the html body (after the DOM is declared)?

@lindsayplatt
Copy link
Author

Oops, you're right on that one. Wasn't thinking when I wrote that. Well, we can do d3 modules + our other custom js! I corrected my initial comment.

@lindsayplatt lindsayplatt self-assigned this Jun 8, 2018
@lindsayplatt lindsayplatt mentioned this issue Jun 8, 2018
Merged
@plor
Copy link

plor commented Jun 21, 2018

good job on this one 👍, you're probably already planning it, but this feature would be a great one to have in vizlab proper.

@lindsayplatt
Copy link
Author

We are looking into using webpack, which might make this custom function irrelevant. First attempt in a new repo: USGS-VIZLAB/gage-conditions#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lindsayplatt lindsayplatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@plor @aappling-usgs @lindsayplatt