Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPlayerJoinDGroupEvent.getDPlayer() glitch #661

Closed
mkcoldwolf opened this issue Sep 20, 2019 · 3 comments
Closed

DPlayerJoinDGroupEvent.getDPlayer() glitch #661

mkcoldwolf opened this issue Sep 20, 2019 · 3 comments
Labels
Milestone

Comments

@mkcoldwolf
Copy link

mkcoldwolf commented Sep 20, 2019

Description
In DPlayerJoinDGroupEvent
both method

  • event.getDGroup.getCaptain();
  • event.getDPlayer();
    kinda glitched
    for #getCaptain(); , it return null when player creating the group, i can understand this sinces the group object may not be exist before this event
    for #getDPlayer(); , it always return null when player join a dgroup, but its fine when player creating a group, this is a serious glitch and has to be fixed

Reproduce
Code:
image
Result:
image

Expected behavior
#getDPlayer(); should return the player who is join the group when this event fire

Screenshots / GIFs / videos
as in //Reproduce

Relevant configuration files
N.A.

@Sataniel98 Sataniel98 added the BUG label Sep 20, 2019
@RogerPlaysMC
Copy link

Yes, it is not functioning as intended. The DPlayer object is created when they either join a group or enter a dungeon. Since it’s not created yet when this event fires it is bound to return null.

Might make more sense in this case to return DGlobalPlayer.

@Sataniel98
Copy link
Member

Sorry for the late reply! The events will be replaced with alternatives in the API module soon. This will be fixed on that occasion.

@Sataniel98 Sataniel98 added this to the Beta 0.18 milestone Apr 17, 2020
@Sataniel98
Copy link
Member

The new event API is finished now, but I've made a simple plugin that prints every fired DXL event to the chat. Minor changes might still be done when I've done some testing with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants