Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample is_control #168

Open
MatthewMah opened this issue Jan 30, 2025 · 0 comments
Open

Sample is_control #168

MatthewMah opened this issue Jan 30, 2025 · 0 comments

Comments

@MatthewMah
Copy link
Contributor

The current implementation checks only the control letter. This is mostly correct. Newer controls do not bother to create fake samples.

The problem arises from collaborator products (at least extracts) sent that were processed normally and given sample numbers. Some of these are actually controls, for example: S25321.

Proposal:
Validate sample by checking that all layout elements corresponding to a sample at all stages (lysate, extract, library, capture) agree on control type.
Compute by returning control type of any layout element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant