Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Runtime error when Pandas Series is not always of string type #1024

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

fanszoro
Copy link
Contributor

Pull Request Description

I. Change Description

This commit fixes the runtime error that occurs when the series is not always of the string type. In the previous code logic, there might have been an overly simplistic assumption about the type of series. When the series contains non - string type data, it leads to runtime errors, affecting the normal operation of the program. This fix adds type checking and corresponding handling logic to ensure that the program can run correctly regardless of the type of series, enhancing the robustness and stability of the code.

Copy link

mergify bot commented Feb 20, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@fanszoro fanszoro changed the title Fix: Runtime error when Pandas Series is not always of string type fix: Runtime error when Pandas Series is not always of string type Feb 20, 2025
@nikos-livathinos
Copy link
Collaborator

@fanszoro your code needs a proper formatting.
Please check here how to install and run pre-commit.

@fanszoro fanszoro force-pushed the main branch 2 times, most recently from c6b47ee to dfdfa9d Compare February 20, 2025 10:32
Copy link
Collaborator

@nikos-livathinos nikos-livathinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nikos-livathinos nikos-livathinos merged commit 6796f0a into DS4SD:main Feb 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants