Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: showcase RAG with LlamaIndex and LangChain #71

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

vagenas
Copy link
Contributor

@vagenas vagenas commented Sep 11, 2024

No description provided.

Signed-off-by: Panos Vagenas <35837085+vagenas@users.noreply.github.com>
Copy link

@staar staar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Panos, could you also add some simplistic tests for the rag, just to ensure we capture if we would break something?

@vagenas
Copy link
Contributor Author

vagenas commented Sep 11, 2024

@staar if/when the extensions (Reader, NodeParser etc.) get incorporated into the Docling API (or upstream frameworks?), one should indeed consider the necessary testing. The scope of this PR though is just adding some showcase notebooks; it does not modify the actual Docling API or its implementation.

@vagenas vagenas merged commit 53569a1 into main Sep 11, 2024
7 checks passed
@vagenas vagenas deleted the add-rag-examples branch September 11, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants