Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Test cases for RTL programmatic PDFs and fixes for the formula model #903

Merged
merged 22 commits into from
Feb 7, 2025
Merged

fix: Test cases for RTL programmatic PDFs and fixes for the formula model #903

merged 22 commits into from
Feb 7, 2025

Conversation

dolfim-ibm
Copy link
Contributor

@dolfim-ibm dolfim-ibm commented Feb 6, 2025 •
edited by cau-git
Loading

  • fix: Support for RTL programmatic documents
  • fix(parser): detect and handle rotated pages
  • fix(parser): fix bug causing duplicated text
  • fix(formula): improve stopping criteria
  • chore: update lock file
  • fix: temporary constrain beautifulsoup (see Release beautifulsoup version constrain #902)

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

Matteo-Omenetti and others added 18 commits February 4, 2025 13:28
switch to code formula model v1.0.1 and new test pdf
48c5714 
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
switch to code formula model v1.0.1 and new test pdf
89844a5 
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
@PeterStaar-IBM
cleaned up the data folder in the tests
5db82d5 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
switch to code formula model v1.0.1 and new test pdf
68d1713 
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
@PeterStaar-IBM
added three test-files for right-to-left
d7c9874 
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
fix black
297e837 
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
added new gt for test_e2e_conversion
8040a4f 
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
added new gt for test_e2e_conversion
9f6aa03 
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
@cau-git
Add code to expose text direction of cell
7bdd686 
Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
new test file
6fd8666 
Signed-off-by: Matteo-Omenetti <Matteo.Omenetti1@ibm.com>
@dolfim-ibm
update lock
6ccff9a 
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm
Merge remote-tracking branch 'origin/dev/add-r2l-tests' into multiple…
fce6bb1 
…-updates

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm
fix mypy reports
69e8a9d 
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm
Merge remote-tracking branch 'origin/main' into multiple-updates
6d801ef 
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm
fix example filepaths
23e82a5 
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm
add test data results
81a6d16 
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm
pin wheel of latest docling-parse release
9097f6d 
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm
use latest docling-core
8e5ecad 
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@mergify Mergify
Copy link

mergify bot commented Feb 6, 2025 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

🟢 Require two reviewer for test updates

Wonderful, this rule succeeded.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

This was referenced Feb 6, 2025
Closed
Closed
Closed
@dolfim-ibm
remove debugging code
fa0a788 
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm
fix path to files in example
b7f5cdb 
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
cau-git
cau-git previously requested changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@cau-git cau-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we proceed I need to first edit out the RTL-related commits which should not have been taken up into this.

@cau-git
Revert unwanted RTL additions
8979abd 
Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
@cau-git cau-git dismissed their stale review February 6, 2025 18:11

Addressed.

@cau-git
Fix test data paths in examples
d7df1ea 
Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
@cau-git cau-git changed the title feat: Support for RTL programmatic documents and fixes for the formula model feat: Test cases for RTL programmatic PDFs and fixes for the formula model Feb 6, 2025
@cau-git cau-git changed the title feat: Test cases for RTL programmatic PDFs and fixes for the formula model fix: Test cases for RTL programmatic PDFs and fixes for the formula model Feb 6, 2025
@cau-git cau-git requested a review from vagenas February 6, 2025 18:31
PeterStaar-IBM
PeterStaar-IBM approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@dolfim-ibm dolfim-ibm merged commit 9114ada into main Feb 7, 2025
10 checks passed
@dolfim-ibm dolfim-ibm deleted the multiple-updates branch February 7, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cau-git cau-git cau-git approved these changes

@PeterStaar-IBM PeterStaar-IBM PeterStaar-IBM approved these changes

@vagenas vagenas Awaiting requested review from vagenas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dolfim-ibm @vagenas @cau-git @PeterStaar-IBM