Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce the enable_remote_services option to allow remote connections while processing #941

Merged
merged 4 commits into from
Feb 12, 2025
Merged

feat: Introduce the enable_remote_services option to allow remote connections while processing #941

merged 4 commits into from
Feb 12, 2025

Conversation

dolfim-ibm
Copy link
Contributor

Implement the new design for allowing calls to remote services as described in #768.

Issue resolved by this Pull Request:
Resolves #840.

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

@dolfim-ibm
feat: Introduce the allow_remote_services option to allow remote conn…
291c91f 
…ections while processing

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@mergify Mergify
Copy link

mergify bot commented Feb 11, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@dolfim-ibm
add option in the example
6b1d88b 
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
PeterStaar-IBM
PeterStaar-IBM previously approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dolfim-ibm
enhance docs
9c3a70a 
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
cau-git
cau-git previously approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@cau-git cau-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! 📞 🏠

@vagenas
Copy link
Contributor

vagenas commented Feb 11, 2025

My concern with this allow_remote_services is that it looks like "permissions", however in reality it is not enforced by the framework but rather it is up to each model implementation to respect it (or not).

@dolfim-ibm
rename to enable_remote_services
654b806 
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm dolfim-ibm changed the title feat: Introduce the allow_remote_services option to allow remote connections while processing feat: Introduce the enable_remote_services option to allow remote connections while processing Feb 12, 2025
@dolfim-ibm dolfim-ibm merged commit 2716c7d into main Feb 12, 2025
10 checks passed
@dolfim-ibm dolfim-ibm deleted the feat-remote-apis branch February 12, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cau-git cau-git cau-git approved these changes

@PeterStaar-IBM PeterStaar-IBM PeterStaar-IBM left review comments

@vagenas vagenas Awaiting requested review from vagenas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add options to control connections to remote apis
4 participants
@dolfim-ibm @vagenas @cau-git @PeterStaar-IBM