Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FHIR Parser should accommodate elements with multiple cardinality. #54

Open
cooperthompson opened this issue May 3, 2024 · 1 comment · Fixed by #122
Open

FHIR Parser should accommodate elements with multiple cardinality. #54

cooperthompson opened this issue May 3, 2024 · 1 comment · Fixed by #122
Assignees
Labels
dedupliFHIR DedupliFHIR repo tickets enhancement New feature or request

Comments

@cooperthompson
Copy link

Describe the bug
For many demographics, it is possible for a single patient to have multiple values for that demographic.

For example, a person may have multiple addresses. The address list may include both current and past addresses, as well as temporary addresses (e.g., hotel), or the patient may just live intermittently at different locations (for example, a child whose parents split custody). Similarly with telecom information (both phone numbers, and e-mail addresses).

Also, in FHIR, the middle name is usually represented as second repetition of the given name component, so in order or middle name to be used as an input or matching, all repetitions of the given name should be accounted for.

To Reproduce
I didn't reproduce this - rather, I'm reporting this based on code review of the read_fhir_data method.

Expected behavior
Patient de-duplication should handle patients that have multiple values for:

  • Addresses
  • Address lines in a single address
  • Phone Numbers
  • E-mail addresses
  • Give Names
  • etc.

While I am reporting this for the FHIR parser, QRDA will usually allow for similar data repetitions to FHIR.

Actual behavior
It appears like the FHIR parser only grabs the first repetition of several elements.

@IsaacMilarky IsaacMilarky self-assigned this May 7, 2024
@IsaacMilarky IsaacMilarky added the enhancement New feature or request label May 7, 2024
@IsaacMilarky
Copy link
Collaborator

This is a good feature to add in the future. It seems very feasible from the expected behavior. I will work on this and update when a PR is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dedupliFHIR DedupliFHIR repo tickets enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants