Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deque Analysis] "No Thumbnail" SVG inline image has insufficient color contrast #1162

Closed
tdonohue opened this issue May 7, 2021 · 3 comments · Fixed by #1219
Closed

[Deque Analysis] "No Thumbnail" SVG inline image has insufficient color contrast #1162

tdonohue opened this issue May 7, 2021 · 3 comments · Fixed by #1219
Assignees
Milestone

Comments

@tdonohue
Copy link
Member

tdonohue commented May 7, 2021

Deque Analysis Summary

The "No Thumbnail" image displayed (e.g. on Item view page) when an Item is missing a thumbnail has color contrast issues.

Text content lacks 4.5:1 contrast ratio. Foreground: #AAAAAA Background: #FFFFFF The contrast ratio is: 2.3:1

Deque issue ticket IDs: 469999, 471020

NOTE: In a separate ticket, Deque also noted that this might be changed from a image to HTML (styled with CSS to perhaps look like an image) as that's more accessible than an inline image. See #1169

Recommended Fix

Make the foreground text darker. Likely something like #757575, though other colors that pass AA compliance are fine. See this tool https://dequeuniversity.com/rules/axe/4.1/color-contrast?application=axeAPI

More Information / Tools

@tdonohue
Copy link
Member Author

tdonohue commented May 7, 2021

@artlowel : Assigning this to you / your team for analysis.

@artlowel
Copy link
Member

Since the base64 string isn't exactly easy to change (for us in this case, but also for institutions that might want to customize it later) I'd go with the HTML approach:

Replacing the default fallback image with an HTML version using colors that pass contrast guidelines will take an estimated 2 hours.

This is best done at the same time as #1169

@tdonohue
Copy link
Member Author

Thanks @artlowel . Sounds good...adding estimate (to both) and keeping assigned to you for your team to work on.

@tdonohue tdonohue added e/2 Estimate in hours and removed Estimate TBD labels May 17, 2021
@ybnd ybnd mentioned this issue May 31, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants