-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several minor SEO issues in HTML <meta>
tags
#1197
Comments
@artlowel : Assigning this to you for your team to look at. These were found during testathon by a tester & I've verified them & suggested possible fixes. |
This can be fixed in an estimated 4 hours For the |
@artlowel : I think we should error on the side of including the Thanks for the estimate. I'll add it & assign back to you for your team to work on when you are read. |
I noticed that currently citation_pdf_url doesn't contain the origin e.g. <meta property="citation_pdf_url" content="/bitstreams/619c1973-3f91-4612-8c43-887f5e32672f/download"> I would have expected: <meta property="citation_pdf_url" content="https://demo7.dspace.org/bitstreams/619c1973-3f91-4612-8c43-887f5e32672f/download"> I'm ok with leaving it out as well for Alternatively we could use |
@artlowel : Good catch, I guess I overlooked that the URL in the HTML is not an absolute URL. My understanding is it is supposed to contain the Origin. According to https://scholar.google.com/intl/en/scholar/inclusion.html#indexing
So, both |
Describe the bug
There are 5 minor issues in our HTML
<meta>
tags at this time. I decided to copy them all into a single ticket as they are most easily tackled by one person. All of these issues appear to be in our MetadataService which generates these tags.citation_pdf_url
has incorrect logic as it requires the bitstream be PDF format. Google Scholar previously told us to change that logic in DS-1483 and then update it in DS-3127 -- better logic for 7.x is listed below.citation_abstract_html_url
often points at localhost URLs (as it uses theui
settings in yourenvironment.*.ts
) This is reproducible on the demo site, e.g. https://demo7.dspace.org/entities/publication/3149d355-7c13-4abb-8537-1852c181d9b2 (use "inspect" on the page).og:title
andog:description
tags should be removed. These are hardcoded to reference DSpace (in general) and are unnecessary at this time since we don't support other "open graph" meta tags. Plus we already have a "generator" tag to specify that the site is DSpace.citation_date
tag should be renamed tocitation_publication_date
as that's the new tag that Google Scholar uses. See also https://scholar.google.com/intl/en/scholar/inclusion.html#indexingcitation_publisher
tag to list the value ofdc.publisher
(if field exists)Expected behavior
citation_pdf_url
should use the following logic (based on the two old JIRA tickets above):citation_pdf_url
(regardless of format -- this overrides the whitelist)citation_pdf_url
(regardless of format -- this overrides the whitelist)citation_abstract_html_url
should not use theenvironment.ui
settings. It likely can just use the value ofdc.identifier.uri
(which is the handle or public URL stored in metadata). If that value isn't found, it could be built similar to thecitation_pdf_url
.3-5 are self explanatory
The text was updated successfully, but these errors were encountered: