Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deque Analysis] Edit Item, Bitstreams Tab: "Content should be in a data table but is not" (Critical Issue) #1270

Closed
tdonohue opened this issue Jul 12, 2021 · 5 comments · Fixed by #3464
Assignees
Labels
accessibility bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Item (Archived) Item display or editing Difficulty: High Estimated at more than 16 hours e/60 Estimate in hours funded Task is funded via the DSpace Development Fund medium priority
Milestone

Comments

@tdonohue
Copy link
Member

Critical: This issue results in blocked content for people with disabilities, and will definitely prevent them from accessing fundamental features or content. This type of issue puts your organization at risk. Prioritize fixing as soon as possible, within the week if possible. Remediation should be a top priority.

Deque Analysis Summary

(Issue ID: 470946) Edit Item, Bitstreams tab: "Content should be in a data table but is not." The page appears visually as a table, but it is not represented as a <table>. Ideally, this will be fixed as follows:

Fix this issue by doing ALL of the following:

  • Markup data that appears logically as a table using <table>, <tr>, and <td> elements.
  • Ensure that header cell and data cell relationships are correctly conveyed according to the complexity of the table.
  • If possible, add a <caption> element as the first child of the <table> element containing the name or title of the table.
  • See also https://dequeuniversity.com/class/semantic-structure2/tables/

The full issue (which includes links for more info) can be found at this link (requires login): https://axeauditor.dequecloud.com/test-run/0856438a-a19a-11eb-bc31-b7d5be387c86/issues?activeTab=dt-issue&page=0&pageSize=100&sortField=ordinal&sortDir=asc&row=9&filter%5Bseverity%5D=4&filter%5Bpage_number%5D=12&filter%5Bpage_number%5D=13&filter%5Bpage_number%5D=14&filter%5Bpage_number%5D=15

More Information / Tools

@atarix83
Copy link
Contributor

@tdonohue

the solution of this issue is not trivial since it requires a complete refactoring of the components in order to be rendered as a table.
The estimation is about 60hours and in our opinion benefits are not commensurate with the cost

@tdonohue
Copy link
Member Author

@atarix83 : Thanks for your honest estimate & opinion on this ticket. Given that feedback, I'll add your estimate to this ticket...and I'll decrease the priority to medium priority for now. I'll also flag it as needing a volunteer, in case there are others out there interested in such a refactor, even if it only provides accessibility benefits.

@tdonohue tdonohue added Difficulty: High Estimated at more than 16 hours e/60 Estimate in hours medium priority help wanted Needs a volunteer to claim to move forward and removed high priority Estimate TBD labels Nov 10, 2021
@tdonohue tdonohue removed their assignment Nov 10, 2021
@tdonohue tdonohue moved this from 🆕 Triage to 🙋 Needs Help / Unscheduled in DSpace Backlog Mar 9, 2023
@github-project-automation github-project-automation bot moved this to 🆕 Triage in DSpace Backlog Mar 9, 2023
@artlowel artlowel self-assigned this Aug 22, 2024
@artlowel artlowel removed the help wanted Needs a volunteer to claim to move forward label Aug 22, 2024
@artlowel
Copy link
Member

Atmire would like to claim this issue as well as #3154 and #1191, and refactor this page to solve them all

@tdonohue tdonohue added claimed: Atmire Atmire team is working on this issue & will contribute back funded Task is funded via the DSpace Development Fund labels Aug 27, 2024
@artlowel
Copy link
Member

@tdonohue This already had an estimate of 60 hours. That looks correct

@tdonohue
Copy link
Member Author

tdonohue commented Aug 30, 2024

More information on this issue from original Deque report:

Description

Data table - General: The content visually appears to be a data table but is not marked up as one.

Element:

  • Bitstreams data table

Recommendation to fix

RULE :
Tabular data SHOULD be represented in a <table>.

HOW TO FIX:
Fix this issue by doing ALL of the following:

  1. Markup data that appears logically as a table using <table>, <tr>, and <td> elements.
  2. Ensure that header cell and data cell relationships are correctly conveyed according to the complexity of the table.
  3. If possible, add a <caption> element as the first child of the <table> element containing the name or title of the table.

REFERENCE:
Deque University: https://dequeuniversity.com/class/semantic-structure2/tables/
W3C-WAI tutorial: https://www.w3.org/WAI/tutorials/tables/

BACKGROUND:
People who are blind cannot see the organizational structure of a table with data arranged in rows and columns with corresponding header cells. In order for screen reader users to understand the logical relationships of data arranged in a table, tables need HTML markup that indicates header cells and data cells and defines their relationship. When tables are marked correctly, screen reader users are able to navigate data tables from cell to cell, in a multi-directional way (up, down, right, left), much like navigating a spreadsheet. As they move from cell to cell, screen readers will read the associated header labels.

@tdonohue tdonohue removed this from DSpace Backlog Dec 6, 2024
@github-project-automation github-project-automation bot moved this to 📋 To Do in DSpace 9.0 Release Dec 6, 2024
@tdonohue tdonohue moved this from 📋 To Do to 🏗 In Progress in DSpace 9.0 Release Dec 6, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in DSpace 9.0 Release Dec 17, 2024
@tdonohue tdonohue moved this from 📋 To Do to ✅ Done in DSpace 8.x and 7.6.x Maintenance Dec 17, 2024
@tdonohue tdonohue added this to the 7.6.3 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug claimed: Atmire Atmire team is working on this issue & will contribute back component: Item (Archived) Item display or editing Difficulty: High Estimated at more than 16 hours e/60 Estimate in hours funded Task is funded via the DSpace Development Fund medium priority
Projects
Development

Successfully merging a pull request may close this issue.

3 participants