Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(collapse): fix calc content height failed because of height: 100% #194

Merged
merged 1 commit into from
Jun 22, 2021
Merged

fix(collapse): fix calc content height failed because of height: 100% #194

merged 1 commit into from
Jun 22, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 修复 collapse panel 高度计算错误的情况，主要原因是因为当设置了 content 的 height: 100% 以后，会导致 getBoundingClientRect 拿到的高度有问题，所以不能够通过设置 height:100% 来撑高内容的高度

主要变更

  • 移除 content 的 height 样式
  • 通过给 contentDom 直接赋值高度的方式来撑高度

@wewoor wewoor merged commit f6a6ba6 into main Jun 22, 2021
@wewoor wewoor deleted the fix/collapse branch June 22, 2021 08:54
@mortalYoung mortalYoung mentioned this pull request Jun 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mortalYoung @wewoor